Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Use pre-commit for CI lint #3464

Merged
merged 11 commits into from
Aug 8, 2024
Merged

ci: Use pre-commit for CI lint #3464

merged 11 commits into from
Aug 8, 2024

Conversation

paulgessinger
Copy link
Member

  • Formatting C++ and Python files
  • Check trailing whitespace
  • Check consistent newlines
  • Check YAML contents

@paulgessinger
ci: Use pre-commit for CI lint
14c3987 
- Formatting C++ and Python files
- Check trailing whitespace
- Check consistent newlines
- CHeck YAML contents
@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Aug 1, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Fatras Affects the Fatras module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Component - Documentation Affects the documentation Seeding Track Finding Ambiguity Resolution labels Aug 1, 2024
@AJPfleger AJPfleger self-requested a review August 1, 2024 08:12
@paulgessinger paulgessinger added this to the next milestone Aug 1, 2024
@paulgessinger paulgessinger marked this pull request as ready for review August 1, 2024 08:23
@paulgessinger
Copy link
Member Author

I'm planning to follow this up with a bump of clang-format to v18, and an introduction of cmake file formatting.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024 •
edited
Loading

📊: Physics performance monitoring for 728d35e

Full contents

physmon summary

andiwand
andiwand reviewed Aug 7, 2024
View reviewed changes
Examples/Scripts/Digitization/error_parameterisation.py Show resolved Hide resolved
cmake/pythia8307-cpp20.patch Outdated Show resolved Hide resolved
docs/core/misc/figures/AxisBoundaryTypes.svg Outdated Show resolved Hide resolved
andiwand
andiwand previously approved these changes Aug 7, 2024
View reviewed changes
@kodiakhq kodiakhq bot removed the automerge label Aug 8, 2024
@kodiakhq kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 8, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@paulgessinger
Merge remote-tracking branch 'origin/main' into ci-pre-commit
e361a98 
# Conflicts:
#	thirdparty/traccc/CMakeLists.txt
@paulgessinger
Copy link
Member Author

@andiwand this had a conflict, which should be resolved now.

@paulgessinger paulgessinger merged commit 2c1d019 into acts-project:main Aug 8, 2024
30 of 43 checks passed
@paulgessinger paulgessinger deleted the ci-pre-commit branch August 8, 2024 09:23
@github-actions github-actions bot removed the automerge label Aug 8, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@acts-project-service
Copy link
Collaborator

✅ Athena integration test results [2c1d019]

✅ All tests successful

status job report
🟢 report_pull_request
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco
🟢 test_ActsDumpGeometryIdentifiers
🟢 test_ActsCheckObjectCountsCachedWorkflow
🟢 test_ActsCheckObjectCountsWorkflow
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🟢 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsWorkflowHeavyIons
🟢 test_ActsWorkflowFastTracking
🟢 test_ActsWorkflowCached
🟢 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🟢 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🟢 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_unit_tests

@paulgessinger paulgessinger modified the milestones: next, v36.1.0 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andiwand andiwand andiwand approved these changes

@AJPfleger AJPfleger Awaiting requested review from AJPfleger

Assignees
No one assigned
Labels
Ambiguity Resolution Component - Core Affects the Core module Component - Documentation Affects the documentation Component - Examples Affects the Examples module Component - Fatras Affects the Fatras module Component - Plugins Affects one or more Plugins Infrastructure Changes to build tools, continous integration, ... Seeding Track Finding
Projects
None yet
Milestone
v36.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@paulgessinger @acts-project-service @andiwand